diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2015-03-14 21:32:35 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2015-03-21 01:52:53 +0100 |
| commit | 38d6ff31b7a5556731ace24fdc41cbc7b9f536e3 (patch) | |
| tree | 204c8228ea9b36152e7a3b427bba613d39004a4d | |
| parent | b0cd6fb590810174296e65b362cc1d62a5b63051 (diff) | |
| download | ffmpeg-38d6ff31b7a5556731ace24fdc41cbc7b9f536e3.tar.gz | |
avformat/mov: Disallow ".." in dref unless use_absolute_path is set
as this kind of allows to circumvent it to some extend.
We also could add a separate parameter or value to choose this
Found-by: ramiro
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 1e4d0498df6621143da1a550006ddc3526ad51cb)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavformat/mov.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c index 01600799ca..367752e1c9 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2489,6 +2489,9 @@ static int mov_open_dref(AVIOContext **pb, const char *src, MOVDref *ref, av_strlcat(filename, "../", sizeof(filename)); av_strlcat(filename, ref->path + l + 1, sizeof(filename)); + if (!use_absolute_path) + if(strstr(ref->path + l + 1, "..") || ref->nlvl_from > 1) + return AVERROR(ENOENT); if (strlen(filename) + 1 == sizeof(filename)) return AVERROR(ENOENT); |