diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2014-11-25 14:45:30 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2014-11-25 14:48:04 +0100 |
| commit | 3d5d95db3f5d8e2093e9e19d0c46e86f54ed2a5d (patch) | |
| tree | c9036152a6a6eb219bb03258b1e07eee1c55cc7f | |
| parent | 0eecf40935b22644e6cd74c586057237ecfd6844 (diff) | |
| download | ffmpeg-3d5d95db3f5d8e2093e9e19d0c46e86f54ed2a5d.tar.gz | |
avcodec/utils: Check that the data is complete in avpriv_bprint_to_extradata()
Fixes out of array read
Fixes: asan_heap-oob_4d2250_814_cov_2745172097_JACOsub_capability_tester.jss
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/utils.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/libavcodec/utils.c b/libavcodec/utils.c index bf2a5b93cc..c06a733786 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -3731,6 +3731,11 @@ int avpriv_bprint_to_extradata(AVCodecContext *avctx, struct AVBPrint *buf) ret = av_bprint_finalize(buf, &str); if (ret < 0) return ret; + if (!av_bprint_is_complete(buf)) { + av_free(str); + return AVERROR(ENOMEM); + } + avctx->extradata = str; /* Note: the string is NUL terminated (so extradata can be read as a * string), but the ending character is not accounted in the size (in |