diff options
| author | Dale Curtis <dalecurtis@chromium.org> | 2015-01-05 16:34:17 -0800 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2015-01-06 18:28:35 +0100 |
| commit | 27a910a8575879d08edaae9d8956ab6d1821044a (patch) | |
| tree | 44a5f902e6932684cf12dd56c2089fa77d2fecf8 | |
| parent | ffe915b6f596de5fc54eabf631b7b9b1a19aaa63 (diff) | |
| download | ffmpeg-27a910a8575879d08edaae9d8956ab6d1821044a.tar.gz | |
mov: Fix negative size calculation in mov_read_default().
The previous code assumed if an atom was marked with a 64-bit
size extension, it actually had that data available. The new
code verfies there's enough data in the atom for this to be
done.
Failure to verify causes total_size > atom.size which will
result in negative size calculations later on.
Found-by: Paul Mehta <paul@paulmehta.com>
Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 3ebd76a9c57558e284e94da367dd23b435e6a6d0)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavformat/mov.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c index d7e5669c8e..4f4dcc9991 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3208,7 +3208,7 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) } } total_size += 8; - if (a.size == 1) { /* 64 bit extended size */ + if (a.size == 1 && total_size + 8 <= atom.size) { /* 64 bit extended size */ a.size = avio_rb64(pb) - 8; total_size += 8; } |